From: Dmitry Marakasov Date: Wed, 12 Mar 2014 00:57:02 GMT Subject: Re: [PATCH] configure.ac: link with -liconv for locale_charset() Message-ID: <20140312005702.GA81282@hades.panopticon> In-Reply-To: * Junio C Hamano (gitster@pobox.com) wrote: > Looks sensible; Dilyan, any comments? Another addendum, comment from Tijl Coosemans who just fixed this problem in FreeBSD ports (differently): --- Please let upstream know they should either use iconv from libc + nl_langinfo from libc, or iconv from libiconv + locale_charset from libiconv, but not mix the two. Actually they could just always use nl_langinfo when it's available because locale_charset is not much more than an alias for it. --- The fix used in ports was to just disable check for libcharset.h: http://www.freebsd.org/cgi/query-pr.cgi?pr=187326#reply3 -- Dmitry Marakasov . 55B5 0596 FF1E 8D84 5F56 9510 D35A 80DD F9D2 F77D amdmi3@amdmi3.ru ..: jabber: amdmi3@jabber.ru http://www.amdmi3.ru