From: Jeff King <peff@peff.net>
Date: Mon, 03 Mar 2014 18:15:58 GMT
Subject: Re: [PATCH] repack: add `repack.honorpackkeep` config var
Message-ID: <20140303181558.GA16523@sigill.intra.peff.net>
In-Reply-To: <xmqqeh2jrvz8.fsf@gitster.dls.corp.google.com>

On Mon, Mar 03, 2014 at 10:13:47AM -0800, Junio C Hamano wrote:

> > Or the flip side: if the user wants to use .keep, we should drop
> > bitmaps. My point is that we do not know which way the user wants to
> > go, so we should not tie the options together.
> 
> Hmph.  I think the short of your later explanation is "global config
> may tell us to use bitmap, in which case we would need a way to
> defeat that and have existing .keep honored, and it makes it easier
> to do so if these two are kept separate, because you do not want to
> run around and selectively disable bitmaps in these repositories.
> We can instead do so with repack.packKeptObjects in the global
> configuration." and I tend to agree with the reasoning.

Yes. Do you need a re-roll from me? I think the last version I sent +
the squash to tie the default to bitmap-writing makes the most sense.

-Peff