From: Jeff King <peff@peff.net>
Date: Mon, 17 Feb 2014 23:47:11 GMT
Subject: Re: [BUG?] git http connection reuse
Message-ID: <20140217234711.GA20499@sigill.intra.peff.net>
In-Reply-To: <alpine.DEB.2.00.1402161431230.10435@tvnag.unkk.fr>

On Sun, Feb 16, 2014 at 02:33:06PM +0100, Daniel Stenberg wrote:

> On Sun, 16 Feb 2014, Daniel Stenberg wrote:
> 
> >Right, the problem is there to make sure that a NTLM-auth
> >connection with different credentials aren't re-used. NTLM with its
> >connection-oriented authentication breaks the traditional HTTP
> >paradigms and before this change there was a risk that libcurl
> >would wrongly re-use a NTLM connection that was done with different
> >credentials!
> >
> >I suspect we introduced a regression here with that fix. I'll dig into this.
> 
> Thanks for pointing this out!
> 
> I could repeat this problem with a curl test case so I wrote up two,
> and then I made a fix to curl:
> 
>   https://github.com/bagder/curl/commit/d765099813f5

Thanks for the quick turnaround. I've confirmed that your patch fixes
both my limited test case and Git itself (when using just the curl_easy
interface).

-Peff