From: Jeff King <peff@peff.net>
Date: Thu, 06 Feb 2014 19:40:01 GMT
Subject: Re: [PATCH 5/6] protocol-capabilities.txt: document no-done
Message-ID: <20140206194000.GC14552@sigill.intra.peff.net>
In-Reply-To: <1391699439-22781-6-git-send-email-pclouds@gmail.com>

On Thu, Feb 06, 2014 at 10:10:38PM +0700, Nguyễn Thái Ngọc Duy wrote:

> See 3e63b21 (upload-pack: Implement no-done capability - 2011-03-14)
> and 761ecf0 (fetch-pack: Implement no-done capability - 2011-03-14)
> for more information.

Content looks good. A few minor grammar nits:

> +no-done
> +-------
> +This capability should be only used with smart HTTP protocol. If

split infinitive: s/be only/only be/

I think it would be more customary to say "the smart HTTP protocol",
with the definite article.

> +Without no-done in smart HTTP protocol, the server session would end

Ditto here.

> +and the client has to make another trip to send "done" and the server
> +can send the pack. no-done removes the last round and thus slightly

s/and the server/before the server/ ?

-Peff