From: W. Trevor King <wking@tremily.us>
Date: Mon, 27 Jan 2014 01:59:59 GMT
Subject: Re: [PATCH v5 1/4] submodule: Make 'checkout' update_module explicit
Message-ID: <20140127015959.GT29063@odin.tremily.us>
In-Reply-To: <CAPig+cQweMT6g+GLFfAWg=9hcU7EjQ7eMOjYiMDQ4rennJSsXw@mail.gmail.com>

On Sun, Jan 26, 2014 at 08:32:04PM -0500, Eric Sunshine wrote:
> On Sun, Jan 26, 2014 at 3:45 PM, W. Trevor King <wking@tremily.us> wrote:
> > +                               update_module="checkout"
> 
> Here, you (unnecessarily) quote 'checkout'...
> 
> > -                               update_module= ;;
> > +                               update_module=checkout ;;
> 
> But here you use bare (unquoted) 'checkout'. Bare is probably more
> idiomatic.

Whatever you want ;).  Queued for v6.

Cheers,
Trevor

-- 
This email may be signed or encrypted with GnuPG (http://www.gnupg.org).
For more information, see http://en.wikipedia.org/wiki/Pretty_Good_Privacy