From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 24 Jan 2014 00:15:39 GMT
Subject: Re: [PATCH 3/3] ewah: support platforms that require aligned reads
Message-ID: <20140124001539.GG18964@google.com>
In-Reply-To: <CAFFjANR=ZKmrf6QjkbiD3z1waoYjWV3eWR_1E-qJU9Nr65bFsw@mail.gmail.com>

Vicent Martí wrote:
> On Fri, Jan 24, 2014 at 12:44 AM, Jonathan Nieder <jrnieder@gmail.com> wrote:

>>> +#if __BYTE_ORDER != __BIG_ENDIAN
>>
>> Is this portable?
>
> We explicitly set the __BYTE_ORDER macros in `compat/bswap.h`. In
> fact, this preprocessor conditional is the same one that we use when
> choosing what version of the `ntohl` macro to define, so that's why I
> decided to use it here.

Ah, thanks.  Sorry I missed that.  So feel free to add my reviewed-by
to the patch without my tweak, too.