From: Jeff King <peff@peff.net>
Date: Tue, 31 Dec 2013 10:33:23 GMT
Subject: Re: [PATCH 0/3] t0000 cleanups
Message-ID: <20131231103323.GA14823@sigill.intra.peff.net>
In-Reply-To: <20131230185125.GI20443@google.com>

On Mon, Dec 30, 2013 at 10:51:25AM -0800, Jonathan Nieder wrote:

> I think it can be better, since the commit message left me scratching
> my head while the patch itself seems pretty simple.  How about
> something like the following?

I am fine with that format, though...

> Analysis and fix:
> 
> 	These scratch areas for sub-tests should be under the t0000
> 	trash directory, but because the TEST_OUTPUT_DIRECTORY
> 	setting from the toplevel test leaks into the environment
> 	they are created under the toplevel output directory (typically
> 	t/) instead.  Because some of the sub-tests simulate failures,
> 	their trash directories are kept around.

This is not exactly true. The TEST_OUTPUT_DIRECTORY setting does not
leak. t0000 sets $TEST_DIRECTORY (which it must, so the sub-scripts can
find test-lib.sh and friends), and then TEST_OUTPUT_DIRECTORY uses that
as a default if it is not explicitly set.

The rest of your rewrite looks correct.

-Peff