From: Josh Triplett <josh@joshtriplett.org>
Date: Mon, 30 Dec 2013 20:20:42 GMT
Subject: Re: [PATCH 9/9] trailer: add tests for "git interpret-trailers"
Message-ID: <20131230202042.GJ27213@leaf>
In-Reply-To: <xmqq1u0utfwk.fsf@gitster.dls.corp.google.com>

On Mon, Dec 30, 2013 at 09:19:55AM -0800, Junio C Hamano wrote:
> Christian Couder <chriscool@tuxfamily.org> writes:
> 
> > +# Do not remove trailing spaces below!
> > +cat >complex_message_trailers <<'EOF'
> > +Fixes: 
> > +Acked-by: 
> > +Reviewed-by: 
> > +Signed-off-by: 
> > +EOF
> 
> Just a hint.  I think it is far safer and robust over time to do
> something like this:
> 
> 	sed -e 's/ Z$/ /' <<-\EOF
>         Fixes: Z
>         Acked-by: Z
>         EOF
> 
> instead of a comment, which can warn human developers but does not
> do anything to prevent their editors' auto-fix features from kicking
> in.

This, but for simplicity, since every line needs the trailing space, why
not just use 's/$/ /' and drop the ' Z' on every line?

</bikeshed>

- Josh Triplett