From: Jeff King <peff@peff.net>
Date: Wed, 18 Dec 2013 20:11:01 GMT
Subject: Re: [PATCH 2/3] prune_object_dir(): verify that path fits in the temporary buffer
Message-ID: <20131218201101.GA10507@sigill.intra.peff.net>
In-Reply-To: <xmqqwqj1hqjd.fsf@gitster.dls.corp.google.com>

On Wed, Dec 18, 2013 at 12:07:02PM -0800, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> >> > +			prune_object(path->buf, sha1);
> >> > +			path->len = baselen;
> >> 
> >> This is minor, but I prefer using strbuf_setlen() for this.
> >
> > Good catch. I do not think it is minor at all; my version is buggy.
> > After the loop ends, path->len does not match the NUL in path->buf. That
> > is OK if the next caller is strbuf-aware, but if it were to pass
> > path->buf straight to a system call, that would be rather...confusing.
> 
> Hmph, rmdir(path->buf) at the end of prune_dir() may have that exact
> issue.
> 
> Will squash in the following.

Thanks. Are you picking this up with a commit message, or did you want
me to re-send with the usual message/signoff?

-Peff