From: Jonathan Nieder Date: Sat, 23 Nov 2013 00:47:54 GMT Subject: Re: [PATCH] drop support for "experimental" loose objects Message-ID: <20131123004754.GL4212@google.com> In-Reply-To: <20131123003014.GA11012@sigill.intra.peff.net> Jeff King wrote: > On Fri, Nov 22, 2013 at 04:24:05PM -0800, Jonathan Nieder wrote: >>> t/t1013-loose-object-format.sh | 66 ------------------ >> >> Hmm, not all of these tests are about the "experimental" format. Do >> we really want to remove them all? > > I think so. They were not all testing the experimental format, but they > were about making sure the is-it-experimental heuristic triggered > properly with various zlib settings. > > Now that we do not apply that heuristic, there is nothing (in git) to > test. We feed the contents straight to zlib. Ok, makes sense. In principle the tests are still useful as futureproofing in case git starts to sanity-check the objects as a way to notice corruption earlier or something. But in practice, that kind of futureproofing is probably not worth the extra tests to maintain. For what it's worth, Reviewed-by: Jonathan Nieder