From: SZEDER Gábor <szeder@ira.uka.de>
Date: Mon, 28 Oct 2013 22:13:47 GMT
Subject: Re: [PATCH v2 18/19] t: add basic bitmap functionality tests
Message-ID: <20131028221347.GA32479@goldbirke>
In-Reply-To: <20131025060438.GP23098@sigill.intra.peff.net>

On Fri, Oct 25, 2013 at 02:04:38AM -0400, Jeff King wrote:
> diff --git a/t/t5310-pack-bitmaps.sh b/t/t5310-pack-bitmaps.sh
> new file mode 100755
> index 0000000..0868725
> --- /dev/null
> +++ b/t/t5310-pack-bitmaps.sh
> @@ -0,0 +1,114 @@
> +#!/bin/sh
> +
> +test_description='exercise basic bitmap functionality'
> +. ./test-lib.sh
> +
> +test_expect_success 'setup repo with moderate-sized history' '
> +	for i in $(test_seq 1 10); do
> +		test_commit $i
> +	done &&
> +	git checkout -b other HEAD~5 &&
> +	for i in `test_seq 1 10`; do
> +		test_commit side-$i
> +	done &&

Sorry, style nitpick: could you rewrite this command substitution
using $() like a few lines above?

> +test_expect_success 'setup further non-bitmapped commits' '
> +	for i in `test_seq 1 10`; do
> +		test_commit further-$i
> +	done
> +'

Likewise.


Best,
Gábor