From: Jeff King Date: Sat, 26 Oct 2013 06:39:12 GMT Subject: Re: [PATCH] pathspec: stop --*-pathspecs impact on internal parse_pathspec() uses Message-ID: <20131026063912.GA24499@sigill.intra.peff.net> In-Reply-To: <1382753360-32037-1-git-send-email-pclouds@gmail.com> On Sat, Oct 26, 2013 at 09:09:20AM +0700, Nguyen Thai Ngoc Duy wrote: > Jeff, how about this? > > It's similar to your last suggestion (i.e. relaxing the magic mask > about literal magic). In addition, it forces literal magic > unconditionally in this case, which I think is the right thing to do. > And it will fix other --*-pathspecs as well. Yeah, I think I follow your reasoning. The problem I saw was just about --literal-pathspec, but the real issue is that "blame" does not want magic pathspecs at all, and your new flag turns that off. So it fixes both my problem, as well as "git blame -- :(foo)bar". -Peff