From: Jeff King Date: Sat, 26 Oct 2013 00:26:30 GMT Subject: Re: [PATCH v2 10/19] pack-bitmap: add support for bitmap indexes Message-ID: <20131026002629.GA18324@sigill.intra.peff.net> In-Reply-To: On Fri, Oct 25, 2013 at 04:06:19PM -0700, Junio C Hamano wrote: > Jeff King writes: > > > diff --git a/pack-bitmap.c b/pack-bitmap.c > > new file mode 100644 > > index 0000000..73c52fd > > --- /dev/null > > +++ b/pack-bitmap.c > > @@ -0,0 +1,965 @@ > > +#include > > + > > +#include "cache.h" > > You among all people already know why this is bad, no? Yes, I am well aware of why we do not want it. I thought I removed that, but it appears I missed one. Sorry. -Peff