From: Jeff King Date: Mon, 21 Oct 2013 19:32:23 GMT Subject: Re: [PATCH] Prevent buffer overflows when path is too big Message-ID: <20131021193223.GC29681@sigill.intra.peff.net> In-Reply-To: <20131021191439.GB29681@sigill.intra.peff.net> On Mon, Oct 21, 2013 at 03:14:39PM -0400, Jeff King wrote: > On Mon, Oct 21, 2013 at 09:07:26PM +0200, Erik Faye-Lund wrote: > > > I would argue that this is probably even a bug on Linux, only harder > > (if not impossible) to trigger by accident as there's probably no > > git-client that will generate such trees. But a "malicious" client > > might. > > I've just been poking through the impacts of these overflows, for that > exact reason. I don't think any of them are easily triggerable by > somebody sending you a malicious tree (e.g., the `remove_subtree` one > only triggers when we have seen that tree in the filesystem, so it must > be limited to `PATH_MAX`). Some of them are triggerable if you use > particular options (e.g., the one in `match_order` is easy to trigger if > you use `diff -O`). Actually, I take that back. The one in checkout_entry is quite easy to trigger if the victim checks out your tree. The rest are much harder, though. -Peff -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.