From: Jeff King <peff@peff.net>
Date: Fri, 18 Oct 2013 18:42:50 GMT
Subject: Re: [PATCH 6/9] http: update base URLs when we see redirects
Message-ID: <20131018184250.GA11040@sigill.intra.peff.net>
In-Reply-To: <xmqqk3hawi5y.fsf@gitster.dls.corp.google.com>

On Fri, Oct 18, 2013 at 11:25:13AM -0700, Junio C Hamano wrote:

> Jeff King <peff@peff.net> writes:
> 
> > + * Our basic strategy is to compare "base" and "asked" to find the bits
> > + * specific to our request. We then strip those bits off of "got" to yield the
> > + * new base. So for example, if our base is "http://example.com/foo.git",
> > + * and we ask for "http://example.com/foo.git/info/refs", we might end up
> > + * with "https://other.example.com/foo.git/info/refs". We would want the
> > + * new URL to become "https://other.example.com/foo.git".
> 
> Not "https://other.example.com/foo.git/info/refs"?

I think my use of "the new URL" is ambiguous. I meant "the new base",
from which one could then construct the new refs URL as you suggest.

-Peff