From: Jonathan Nieder Date: Mon, 30 Sep 2013 21:26:36 GMT Subject: Re: [PATCH] Makefile: suppress false positive warnings of empty format string. Message-ID: <20130930212636.GY9464@google.com> In-Reply-To: <20130930201429.GA14433@sigill.intra.peff.net> Jeff King wrote: > I think we'd be better off to > simply mark up the few callsites. Workarounds are here: > > http://article.gmane.org/gmane.comp.version-control.git/230026 Yeah, that looks okay (ugly but tolerable). It's tempting to do something like - status_printf_ln(s, GIT_COLOR_NORMAL, ""); + status_nl(s, GIT_COLOR_NORMAL); and - status_printf(s, color(WT_STATUS_HEADER, s), ""); + status_start_line(s, color(WT_STATUS_HEADER, s)); to make the intent clearer. Sane? Jonathan