From: Jonathan Nieder <jrnieder@gmail.com>
Date: Mon, 30 Sep 2013 19:04:04 GMT
Subject: Re: [PATCH] git-svn: fix signed commit parsing
Message-ID: <20130930190404.GU9464@google.com>
In-Reply-To: <1380552374-26103-1-git-send-email-boklm@mars-attacks.org>

Nicolas Vigier wrote:

> When parsing a commit object, git-svn wrongly think that a line
> containing spaces means the end of headers and the start of the commit
> message. In case of signed commit, the gpgsig entry contains a line with
> one space, so "git svn dcommit" will include part of the signature in
> the commit message.
>
> An example of such problem :
> http://svnweb.mageia.org/treasurer?view=revision&revision=86
>
> This commit changes the regex to only match an empty line as separator
> between the headers and the commit message.
>
> Signed-off-by: Nicolas Vigier <boklm@mars-attacks.org>

Good catch.  For what it's worth,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>