From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Thu, 26 Sep 2013 10:16:48 GMT
Subject: Re: [PATCH v2 0/5] New hash table implementation
Message-ID: <20130926101648.GD6615@paksenarrion.iveqy.com>
In-Reply-To: <52416058.90008@gmail.com>

On Tue, Sep 24, 2013 at 11:50:16AM +0200, Karsten Blees wrote:
> Tests can be reproduced with 'time echo "perfhash[map] <method> 1000" | ./test-hashmap', see test-hashmap.c for definition of method flags.

So I'm still curious about the actual performance improvements for git.
I runned git describe on the linux kernel with both the old hashmap and
this new one:

With old hashmap
================
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.236s
user    0m0.216s
sys     0m0.020s
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.236s
user    0m0.220s
sys     0m0.016s
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.236s
user    0m0.212s
sys     0m0.024s

With new hashmap
================
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.236s
user    0m0.216s
sys     0m0.020s
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.235s
user    0m0.216s
sys     0m0.020s
iveqy@minilla:/srv/slask/linux$ time ../git/git describe
v3.12-rc2-83-g4b97280

real    0m0.235s
user    0m0.208s
sys     0m0.028s


I can't see any improvements at all here. What do I miss? Am I running
git describe in the wrong way? Does linux.git have too few tags to be
important?

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com