From: Jeff King <peff@peff.net>
Date: Tue, 03 Sep 2013 17:46:04 GMT
Subject: Re: [PATCH v3] peel_onion(): add support for <rev>^{tag}
Message-ID: <20130903174604.GD1050@sigill.intra.peff.net>
In-Reply-To: <1378229853-21236-1-git-send-email-rhansen@bbn.com>

On Tue, Sep 03, 2013 at 01:37:33PM -0400, Richard Hansen wrote:

> ---
> Changes since v2 (2013-09-02, see
> <http://thread.gmane.org/gmane.comp.version-control.git/233598>):
>   * add a test case (hopefully I didn't go overboard)

Personally I was thinking just

  test_must_fail git rev-parse HEAD^{tag} &&
  git rev-parse commit-tag >expect &&
  git rev-parse commit-tag^{tag} >actual &&
  test_cmp expect actual

but I do not think it hurts to be more thorough.

Thanks, this version of the patch looks ready to me.

-Peff