From: Jeff King <peff@peff.net>
Date: Tue, 03 Sep 2013 17:20:47 GMT
Subject: Re: [PATCH 0/4] Re: [PATCH 3/4] t: rev-parse-parents: avoid yoda conditions
Message-ID: <20130903172046.GA1050@sigill.intra.peff.net>
In-Reply-To: <20130903170419.GA29921@google.com>

On Tue, Sep 03, 2013 at 10:04:19AM -0700, Jonathan Nieder wrote:

> > It depends on the change, I suppose.  I agree, changing 3k+ lines just
> > to avoid yoda conditions...  I doubt the gain worth the code churn.
> 
> Especially when the idiom being changed is not even being made better.
> ;-)

Yes. IMHO it is not just "not worth the churn" but actively making the
code less readable.

> While at it, I rerolled the other patches from the series to clarify
> their commit messages (replacing "fix <something>" with a fuller
> description).

The series looks fine to me, modulo the fix up in v2 of 4/4.

-Peff