From: Christian Couder Date: Sun, 01 Sep 2013 10:02:28 GMT Subject: Re: [PATCH v3 08/11] t6050-replace: check that -f option bypasses the type check Message-ID: <20130901.120228.1211524158553068971.chriscool@tuxfamily.org> In-Reply-To: From: Eric Sunshine > > On Sat, Aug 31, 2013 at 3:12 PM, Christian Couder > wrote: >> Signed-off-by: Christian Couder >> --- >> t/t6050-replace.sh | 6 ++++++ >> 1 file changed, 6 insertions(+) >> >> diff --git a/t/t6050-replace.sh b/t/t6050-replace.sh >> index 05be228..0b07a0b 100755 >> --- a/t/t6050-replace.sh >> +++ b/t/t6050-replace.sh >> @@ -276,6 +276,12 @@ test_expect_success 'replaced and replacement objects must be of the same type' >> grep "$BLOB. points to a replacement object of type .blob" err >> ' >> >> +test_expect_success '-f option bypasses the type check' ' >> + git replace -f mytag $HASH1 2>err && >> + git replace -f HEAD^{tree} HEAD~1 2>err && >> + git replace -f HEAD^ $BLOB 2>err >> +' > > Is there a non-obvious reason you are redirecting stderr to a file in > this test? Unlike the test added earlier, this one never consults the > error output. By dropping this apparently unnecessary redirection, > diagnosis of a regression potentially becomes simpler since any error > output from git-replace will become visible when the test is run > verbosely. You are right! I will drop these redirections. Thanks, Christian.