From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 25 Aug 2013 06:00:45 GMT
Subject: Re: [PATCH 2/2] dir: test_one_path: fix inconsistent behavior due to missing '/'
Message-ID: <20130825060045.GP2882@elie.Belkin>
In-Reply-To: <1377232155-7300-3-git-send-email-sunshine@sunshineco.com>

Eric Sunshine wrote:

> Although undocumented, directory_exists_in_index_icase(dirname,len)
> unconditionally assumes the presence of a '/' at dirname[len] (despite
> being past the end-of-string). Callers are expected to respect
[...]
>                                                Fix this problem.

So, does this fix the problem by changing
directory_exists_in_index_icase() to be more liberal in what it
accepts, or callers to be more conservative in what they pass in?

Please forgive my laziness.  I ask in order to save future readers the
time of digging into the code.

Thanks,
Jonathan