From: Jeff King Date: Wed, 07 Aug 2013 09:22:20 GMT Subject: Re: [PATCH] l10n: de.po: translate 5 messages Message-ID: <20130807092220.GA4563@sigill.intra.peff.net> In-Reply-To: <87r4e5vp0r.fsf@linux-k42r.v.cablecom.net> On Wed, Aug 07, 2013 at 11:17:08AM +0200, Thomas Rast wrote: > This results from Peff's c17592a (commit: tweak empty cherry pick advice > for sequencer, 2013-07-26): > > diff --git a/builtin/commit.c b/builtin/commit.c > index a17a5df..39717d5 100644 > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -62,8 +62,18 @@ > "If you wish to commit it anyway, use:\n" > "\n" > " git commit --allow-empty\n" > +"\n"); > + > +static const char empty_cherry_pick_advice_single[] = > +N_("Otherwise, please use 'git reset'\n"); > + > +static const char empty_cherry_pick_advice_multi[] = > +N_("If you wish to skip this commit, use:\n" > "\n" > -"Otherwise, please use 'git reset'\n"); > +" git reset\n" > +"\n" > +"Then \"git cherry-pick --continue\" will resume cherry-picking\n" > +"the remaining commits.\n"); > > static const char *use_message_buffer; > static const char commit_editmsg[] = "COMMIT_EDITMSG"; > > [...] > > So it seems that concatenating sentences indeed falls into a gray area > between "avoid sentence lego" and "split at paragraphs". And Peff's > style of splitting it saves the translators work because the first part > of the message is shared among two code paths. Yeah, I was mainly trying to avoid repeating myself, since the first part of the message would be the same (and I did not want them to fall out of sync). However, I do not mind changing it if translators would prefer to see the whole message as a single string. I agree it's a gray area. -Peff