From: Jonathan Nieder Date: Mon, 15 Jul 2013 18:13:57 GMT Subject: Re: [RFC/PATCH] Add the NO_SENTINEL build variable Message-ID: <20130715181357.GF14690@google.com> In-Reply-To: <51E4338E.4090003@ramsay1.demon.co.uk> Ramsay Jones wrote: > One of the three gcc compilers that I use does not understand the > sentinel function attribute. (so, it spews 108 warning messages) Do you know what version of gcc introduced the sentinel attribute? Would it make sense for the ifdef in git-compat-util.h to be keyed on __GNUC__ and __GNUC_MINOR__ instead of a new makefile flag? Thanks, Jonathan