From: Jeff King <peff@peff.net>
Date: Fri, 12 Jul 2013 20:44:37 GMT
Subject: Re: [PATCH 3/3] wt-status: use "format" function attribute for status_printf
Message-ID: <20130712204437.GC5276@sigill.intra.peff.net>
In-Reply-To: <7vfvvjoj2h.fsf@alter.siamese.dyndns.org>

On Fri, Jul 12, 2013 at 09:10:30AM -0700, Junio C Hamano wrote:

> > You can "fix" it with -Wno-zero-format-length, so the hassle is not
> > huge. But I am also inclined to just drop this one. We have lived
> > without the extra safety for a long time, and list review does tend to
> > catch such problems in practice.
> 
> I am tempted to actually merge the original one as-is without any of
> the workaround, and just tell people to use -Wno-format-zero-length.

Yeah, I think the only downside is the cognitive burden on individual
developers who try -Wall and have to figure out that we need
-Wno-zero-format-length (and that the warnings are not interesting).

It would be nice to add it automatically to CFLAGS, but I do not know if
we can reliably detect from the Makefile that we are compiling under
gcc.

-Peff