From: Jeff King Date: Wed, 10 Jul 2013 12:00:29 GMT Subject: Re: [PATCH 10/10] pack-revindex: radix-sort the revindex Message-ID: <20130710120029.GA20519@sigill.intra.peff.net> In-Reply-To: <20130710115557.GJ21963@sigill.intra.peff.net> On Wed, Jul 10, 2013 at 07:55:57AM -0400, Jeff King wrote: > 5. We use memcpy instead of an open-coded loop to copy the whole array > at the end. The individual bucket-assignment is still done by > struct assignment. I haven't timed if memcpy would make a > difference there. I just timed this, and I can't measure any difference. I think the struct assignment is the more readable option, and I do not think any compilers should have trouble with it. But if they do, we can switch it for a memcpy. -Peff