From: SZEDER Gábor <szeder@ira.uka.de>
Date: Sat, 22 Jun 2013 13:06:04 GMT
Subject: Re: [PATCH 1/4] t9903: add tests for git-prompt pcmode
Message-ID: <20130622130604.GK20052@goldbirke>
In-Reply-To: <3dd104f19a995081d8c8bf89bc9e33052077e052.1371780085.git.erdavila@gmail.com>

Hi,

On Thu, Jun 20, 2013 at 11:25:26PM -0300, Eduardo R. D'Avila wrote:
> git-prompt.sh lacks tests for PROMPT_COMMAND mode.
> 
> Add tests for:
> * pcmode prompt without colors
> * pcmode prompt with colors for bash
> * pcmode prompt with colors for zsh
> 
> Having these tests enables an upcoming refactor in
> a safe way.
> 
> Signed-off-by: Eduardo R. D'Avila <erdavila@gmail.com>

I doubt the value of separate tests for zsh.  They might make sense as
long as there are different code paths for doing coloring for the two
shells, but after your refactorization in 2/4 there is only one common
block of if statements, which is already thoroughly excercised by your
tests for bash, making the separate tests for zsh redundant.


Gábor