From: Heiko Voigt <hvoigt@hvoigt.net>
Date: Thu, 20 Jun 2013 21:58:12 GMT
Subject: Re: [PATCH] [submodule] Remove duplicate call to set_rev_name
Message-ID: <20130620215812.GA2687@sandbox-ub>
In-Reply-To: <1371462936-9672-1-git-send-email-iveqy@iveqy.com>

Hi,

On Mon, Jun 17, 2013 at 11:55:36AM +0200, Fredrik Gustafsson wrote:
> set_rev_name is a possible expensive operation. If a submodule has
> changes in it, set_rev_name was called twice.
> 
> Solution is to move set_rev_name so it's only called once, no matter the
> codepath taken.

Looks good to me.

Cheers Heiko