From: Jeff King <peff@peff.net>
Date: Thu, 20 Jun 2013 11:55:09 GMT
Subject: Re: [PATCH v2 04/12] refs: implement simple transactions for the packed-refs file
Message-ID: <20130620115508.GB773@sigill.intra.peff.net>
In-Reply-To: <51C2B41F.2050708@alum.mit.edu>

On Thu, Jun 20, 2013 at 09:49:51AM +0200, Michael Haggerty wrote:

> [I just noticed that lock_ref_sha1_basic() leaks a struct lock_file
> every time that it is called.]

I noticed that recently, too. I have a patch series about 90% complete
that abstracts the tempfile handling (the ultimate goal of which is to
optionally clean up tmp_* files in the objects/ directory). It refactors
the lockfile cleanup, and it would not be too hard to have a committed
or rolled-back lockfile actually remove itself from the "to clean at
exit" list.

Which would make it perfectly safe to have a lockfile as an automatic
variable as long as you commit or rollback before leaving the function.

-Peff