From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Fri, 14 Jun 2013 18:27:41 GMT
Subject: Re: [[PATCH v3] 1/2] [submodule] handle multibyte characters in name
Message-ID: <20130614182741.GA5812@paksenarrion.iveqy.com>
In-Reply-To: <7va9msppw7.fsf@alter.siamese.dyndns.org>

On Fri, Jun 14, 2013 at 10:23:52AM -0700, Junio C Hamano wrote:
> Fredrik Gustafsson <iveqy@iveqy.com> writes:
> 
> > ... The
> > correct approach to solve the problem for all pathnames may be to use
> > "ls-files -z" and tell the Perl script that reads its output to read NUL
> > separated records by using $/ = "\0".
> 
> I've tentatively queued the attached without 2/2; the scriptlet is
> small enough not to matter in an eventual rewrite, so it shouldn't
> make a difference either way.

Sorry, I didn't knew enough perl to understand that that was a
suggestion rather than a hint to a future developer.

Now when I see how you meant it's looks like the best solution to me.
To me it looks like we now should be able to handle the multiline case
here. However, git submodule add doesn't handle newline yet, so it
really doesn't matter for now.

Thanks for the help!

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com