From: John Keeping <john@keeping.me.uk>
Date: Fri, 14 Jun 2013 13:10:26 GMT
Subject: Re: [PATCH] format-patch: remove existing output-directory
Message-ID: <20130614130910.GF23890@serenity.lan>
In-Reply-To: <1371213813-7925-1-git-send-email-artagnon@gmail.com>

On Fri, Jun 14, 2013 at 06:13:33PM +0530, Ramkumar Ramachandra wrote:
> The following command
> 
>   $ git format-patch -o outgoing master
> 
> does not ensure that the output-directory outgoing doesn't already
> exist.  As a result, it's possible for patches from two different series
> to get mixed up if the user is not careful.  Fix the problem by
> unconditionally removing the output-directory before writing to it.

I don't think this is the correct behaviour.  I can think of cases where
I would want to output multiple things into the same directory.

It may be better to issue a warning when this happens, or die and
provide a flag to let the user bypass that.