From: Fredrik Gustafsson <iveqy@iveqy.com>
Date: Sun, 09 Jun 2013 19:15:18 GMT
Subject: Re: [PATCH v4 31/45] rebase: trivial cleanup
Message-ID: <20130609191518.GB12122@paksenarrion.iveqy.com>
In-Reply-To: <1370796057-25312-32-git-send-email-felipe.contreras@gmail.com>

On Sun, Jun 09, 2013 at 11:40:43AM -0500, Felipe Contreras wrote:
> -		git_am_opt="$git_am_opt -q"

This one makes me wonder a bit. I'm not sure about how this works in
git, so I would appriciate if someone can explain. I might also have
misunderstood something.

Here we have two sh-scripts (git rebase
and git am) interacting witch eachother. Both uses GIT_QUIET, so if
GIT_QUIET already is set by the caller (git rebase) the callee doesn't
have to set it to.

However GIT_QUIET is undocumented for git-am (in Git Manual). If we
translate git am to C/ruby/python/perl/etc. will we catch this?

This raises a few more generall questions:
do we already pass information between processes(!) with enviroment
variables? And is this documented the way it should be?

-- 
Med vänliga hälsningar
Fredrik Gustafsson

tel: 0733-608274
e-post: iveqy@iveqy.com