From: SZEDER Gábor Date: Fri, 07 Jun 2013 19:16:43 GMT Subject: Re: What's cooking in git.git (Jun 2013, #03; Thu, 6) Message-ID: <20130607191643.GA31625@goldbirke> In-Reply-To: <7v8v2lu5ks.fsf@alter.siamese.dyndns.org> On Fri, Jun 07, 2013 at 11:41:07AM -0700, Junio C Hamano wrote: > "git log -Gcomplete_file -p contrib/completion" found this one: > > commit 1d66ec587e7d903afdf12a81718772a9eadc15a1 > Author: SZEDER Gábor > Date: Thu Mar 10 19:12:29 2011 +0100 > > bash: complete 'git diff ...branc' (snip) > Suggested-by: Junio C Hamano > Signed-off-by: SZEDER Gábor > Signed-off-by: Junio C Hamano > > Now I do not recall suggesting it, and you (and I today after 2 > years) may disagree with the rationale, but at least we can read > what was the "intended" meaning, I think. See http://thread.gmane.org/gmane.comp.version-control.git/167728/focus=168838 I still agree with the rationale, considering that the new __git_complete_revlist_file() function for completing ref1...ref2:path is a nearly straight copy-paste from the then __git_complete_revlist() and __git_complete_file() including that 12 line long sed script. Gábor