From: Jeff King <peff@peff.net>
Date: Thu, 06 Jun 2013 06:37:54 GMT
Subject: Re: [PATCH] t0005: skip signal death exit code test on Windows
Message-ID: <20130606063754.GA20050@sigill.intra.peff.net>
In-Reply-To: <51B02D81.3000700@viscovery.net>

On Thu, Jun 06, 2013 at 08:34:41AM +0200, Johannes Sixt wrote:

> From: Johannes Sixt <j6t@kdbg.org>
> 
> The test case depends on that test-sigchain can commit suicide by a call
> to raise(SIGTERM) in a way that run-command.c::wait_or_whine() can detect
> as death through a signal. There are no POSIX signals on Windows, and a
> sufficiently close emulation is not available in the Microsoft C runtime
> (and probably not even possible).
> 
> The particular deficiency is that when a signal is raise()d whose SIG_DFL
> action will cause process death (SIGTERM in this case), the
> implementation of raise() just calls exit(3).
> 
> We could check for exit code 3 in addition to 143, but that would miss
> the point of the test entirely. Hence, just skip it on Windows.

Thanks. I wasn't quite clear on how the signal handling worked on
Windows, but from your description, I agree there is not any point in
running the test at all.

Acked-by: Jeff King <peff@peff.net>

-Peff