From: Jeff King Date: Thu, 30 May 2013 02:55:54 GMT Subject: Re: t0008-ignores failure Message-ID: <20130530025554.GC19860@sigill.intra.peff.net> In-Reply-To: <20130530025258.GB19860@sigill.intra.peff.net> On Wed, May 29, 2013 at 10:52:58PM -0400, Jeff King wrote: > diff --git a/t/test-lib.sh b/t/test-lib.sh > index ca6bdef..5d84705 100644 > --- a/t/test-lib.sh > +++ b/t/test-lib.sh > @@ -600,7 +600,7 @@ fi > fi > > # Test repository > -TRASH_DIRECTORY="trash directory.$(basename "$0" .sh)" > +TRASH_DIRECTORY="trash directory:$(basename "$0" .sh)" > test -n "$root" && TRASH_DIRECTORY="$root/$TRASH_DIRECTORY" > case "$TRASH_DIRECTORY" in > /*) ;; # absolute path is good > > reveals the breakage on Linux. And it seems that a lot of other tests > break, too. I haven't looked into them yet, though. Hrm. Just picking an example at random, t7006 fails because it uses --exec-path="`pwd`". And of course colons are meaningful in any PATH-like context. It would be nice to be able to handle that case cleanly, but I think we would be breaking compatibility. So while it would be nice to work on paths with colons everywhere, I doubt it is worth the effort to start checking it through the whole test suite. -Peff -- -- *** Please reply-to-all at all times *** *** (do not pretend to know who is subscribed and who is not) *** *** Please avoid top-posting. *** The msysGit Wiki is here: https://github.com/msysgit/msysgit/wiki - Github accounts are free. You received this message because you are subscribed to the Google Groups "msysGit" group. To post to this group, send email to msysgit@googlegroups.com To unsubscribe from this group, send email to msysgit+unsubscribe@googlegroups.com For more options, and view previous threads, visit this group at http://groups.google.com/group/msysgit?hl=en_US?hl=en --- You received this message because you are subscribed to the Google Groups "msysGit" group. To unsubscribe from this group and stop receiving emails from it, send an email to msysgit+unsubscribe@googlegroups.com. For more options, visit https://groups.google.com/groups/opt_out.