From: Jeff King <peff@peff.net>
Date: Wed, 29 May 2013 15:26:53 GMT
Subject: Re: [PATCH v2] git-remote-mediawiki: better error message when HTTP(S) access fails
Message-ID: <20130529152653.GB9072@sigill.intra.peff.net>
In-Reply-To: <1369829189-27881-1-git-send-email-Matthieu.Moy@imag.fr>

On Wed, May 29, 2013 at 02:06:29PM +0200, Matthieu Moy wrote:

> My use-case is an invalid SSL certificate. Pulling from the wiki with a
> recent version of libwww-perl fails, and git-remote-mediawiki gave no
> clue about the reason. Give the mediawiki API detailed error message, and
> since it is not so informative, hint the user about an invalid SSL
> certificate on https:// urls.
> 
> Signed-off-by: Matthieu Moy <Matthieu.Moy@imag.fr>

Thanks, this looks like a reasonable stopping point for now.

There are still some calls that do not check the result of the mediawiki
calls at all, and I think they'll probably cause a perl error when they
fail (for dereferencing undef). But these ones are the initial contact,
so they should be the common ones to fail. Refactoring the whole error
handling is a bit larger task and can wait until somebody is interested.

-Peff