From: Michael S. Tsirkin <mst@redhat.com>
Date: Thu, 23 May 2013 14:37:11 GMT
Subject: Re: [PATCH v2] Document push --no-verify
Message-ID: <20130523143711.GA24037@redhat.com>
In-Reply-To: <ba24ea6f9fedc05690ee93a805d4f468650a942c.1369315855.git.trast@inf.ethz.ch>

On Thu, May 23, 2013 at 03:34:11PM +0200, Thomas Rast wrote:
> ec55559 (push: Add support for pre-push hooks, 2013-01-13) forgot to
> add a note to git-push(1) about the new --no-verify option.
> 
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>


Thanks. FWIW

Reviewed-by: Michael S. Tsirkin <mst@redhat.com>

> ---
> 
> Junio replied privately that it should also mention the --verify
> possibility.
> 
> So why not.  But this needs to be fixed across the board eventually;
> 0f1930c (parse-options: allow positivation of options starting, with
> no-, 2012-02-25) did not update any docs, so none of the other --no-
> options mention their positive forms.
> 
> 
>  Documentation/git-push.txt | 7 ++++++-
>  1 file changed, 6 insertions(+), 1 deletion(-)
> 
> diff --git a/Documentation/git-push.txt b/Documentation/git-push.txt
> index d514813..df5be26 100644
> --- a/Documentation/git-push.txt
> +++ b/Documentation/git-push.txt
> @@ -11,7 +11,7 @@ SYNOPSIS
>  [verse]
>  'git push' [--all | --mirror | --tags] [--follow-tags] [-n | --dry-run] [--receive-pack=<git-receive-pack>]
>  	   [--repo=<repository>] [-f | --force] [--prune] [-v | --verbose] [-u | --set-upstream]
> -	   [<repository> [<refspec>...]]
> +	   [--no-verify] [<repository> [<refspec>...]]
>  
>  DESCRIPTION
>  -----------
> @@ -195,6 +195,11 @@ useful if you write an alias or script around 'git push'.
>  	be pushed. If on-demand was not able to push all necessary
>  	revisions it will also be aborted and exit with non-zero status.
>  
> +--[no-]verify::
> +	Toggle the pre-push hook (see linkgit:githooks[5]).  The
> +	default is \--verify, giving the hook a chance to prevent the
> +	push.  With \--no-verify, the hook is bypassed completely.
> +
>  
>  include::urls-remotes.txt[]
>  
> -- 
> 1.8.3.rc3.486.gfe16094