From: Miklos Vajna <vmiklos@suse.cz>
Date: Fri, 10 May 2013 07:07:13 GMT
Subject: Re: [PATCH v3] cherry-pick: make sure all input objects are commits
Message-ID: <20130510070712.GA24415@suse.cz>
In-Reply-To: <7vsj1v99ve.fsf@alter.siamese.dyndns.org>

On Thu, May 09, 2013 at 01:27:49PM -0700, Junio C Hamano <gitster@pobox.com> wrote:
> I'd apply this before -rc2.  I _think_ it is also OK to just let
> lookup_commit_reference_gently() barf with its standard message
> 
> 	error: Object %s is a %s, not a commit
> 
> without an extra sha1_object_info() call in the error codepath, but
> I did not bother, as this is meant to be an emergency fix.

Yes, that makes a lot of sense. I myself never cherry-pick tags, but I
understand that is part of some workflow.