From: Jeff King Date: Thu, 09 May 2013 22:41:25 GMT Subject: Re: [PATCH v3 0/5] allow more sources for config values Message-ID: <20130509224124.GD30774@sigill.intra.peff.net> In-Reply-To: <20130509161636.GB3526@book-mint> On Thu, May 09, 2013 at 06:16:36PM +0200, Heiko Voigt wrote: > This is an update with the comments of the second iteration[1] incorporated. > > [1] http://thread.gmane.org/gmane.comp.version-control.git/217811 > > Heiko Voigt (5): > config: factor out config file stack management > config: drop cf validity check in get_next_char() > config: make parsing stack struct independent from actual data source > teach config --blob option to parse config from database > do not die when error in config parsing of buf occurs Thanks, I think it looks good except for a few minor things I mentioned. -Peff