From: Jeff King <peff@peff.net>
Date: Thu, 09 May 2013 22:30:39 GMT
Subject: Re: [PATCH v3 4/5] teach config --blob option to parse config from database
Message-ID: <20130509223038.GB30774@sigill.intra.peff.net>
In-Reply-To: <20130509162018.GF3526@book-mint>

On Thu, May 09, 2013 at 06:20:18PM +0200, Heiko Voigt wrote:

> +static int config_buf_fgetc(struct config_source *conf)
> +{
> +	if (conf->buf.pos < conf->buf.len && conf->buf.buf[conf->buf.pos])
> +		return conf->buf.buf[conf->buf.pos++];
> +
> +	return EOF;
> +}

It probably would not matter for config reading, but is there any reason
not to make your fgetc replacement 8-bit clean (i.e., to check only len,
and not worry about NUL characters)?

-Peff