From: Jeff King <peff@peff.net>
Date: Sat, 20 Apr 2013 04:26:29 GMT
Subject: Re: [PATCH 0/6] grep with textconv
Message-ID: <20130420042629.GE24970@sigill.intra.peff.net>
In-Reply-To: <7vhaj21ir3.fsf@alter.siamese.dyndns.org>

On Fri, Apr 19, 2013 at 11:24:16AM -0700, Junio C Hamano wrote:

> >   grep: allow to use textconv filters
> 
> This looked mostly sensible except for one minor "eh, do we really
> need to assume textconv output is text, or wouldn't using the same
> codepath for raw blob and textconv result to make them consistently
> honor opt->binary easier to explain?".

I don't mind re-checking the textconv output for binary-ness. But I did
it that way for consistency with the diff code-path, which also assumes
that textconv output is not binary.

> By the way, "git log --no-merges | grep obey | wc -l" shows that we
> say "honor an option" a lot more than "obey an option".  We may want
> to be consistent here.

Yeah, it is a pretty minor thing, but I agree that "honor" sounds
better.

-Peff