From: Jeff King <peff@peff.net>
Date: Thu, 18 Apr 2013 16:56:01 GMT
Subject: Re: [PATCH] blame: handle broken commit headers gracefully
Message-ID: <20130418165600.GA24492@sigill.intra.peff.net>
In-Reply-To: <7vsj2oesa6.fsf@alter.siamese.dyndns.org>

On Wed, Apr 17, 2013 at 02:55:29PM -0700, Junio C Hamano wrote:

> Or you can imagine nastier input strings, like
> 
>    Name <>-<email@host> 123456789 -0000
>    Name <ema>-<il@host> 123456789 -0000
>    Name <email@host~ 1234>56789 -0000
> 
> I am afraid that at some point "we should salvage as much as we
> can", which is a worthy goal, becomes a losing proposition.

Good point. In the worst cases, even if you cleaned things up, you might
even need to allocate a new string (like your middle one), which would
make calling split_ident_line a lot more annoying. Probably not worth
the effort.

-Peff