From: Jeff King <peff@peff.net>
Date: Tue, 16 Apr 2013 23:57:12 GMT
Subject: Re: [PATCH 16/33] t3210: test for spurious error messages for dangling packed refs
Message-ID: <20130416235712.GA20585@sigill.intra.peff.net>
In-Reply-To: <7vip3mhxhq.fsf@alter.siamese.dyndns.org>

On Tue, Apr 16, 2013 at 04:22:25PM -0700, Junio C Hamano wrote:

> +static void parse_expire_value(const char *value, unsigned long *expire)
> +{
> +	if (!strcmp(value, "never") || !strcmp(value, "false"))
> +		*expire = 0;
> +	else if (!strcmp(value, "all") || !strcmp(value, "now"))
> +		/*
> +		 * We take over "now" here, which usually translates
> +		 * to the current timestamp, because the user really
> +		 * means everything she has done in the past, and by
> +		 * definition reflogs are the record of the past,
> +		 * there is nothing from the future to be kept.
> +		 */
> +		*expire = ULONG_MAX;
> +	else
> +		*expire = approxidate(value);
> +}

Do we want to use approxidate_careful here to catch other junk?

-Peff