From: Jeff King <peff@peff.net>
Date: Mon, 15 Apr 2013 00:47:46 GMT
Subject: Re: [PATCH v2] branch: colour upstream branches
Message-ID: <20130415004746.GA6477@sigill.intra.peff.net>
In-Reply-To: <1365982707-25455-1-git-send-email-felipe.contreras@gmail.com>

On Sun, Apr 14, 2013 at 06:38:27PM -0500, Felipe Contreras wrote:

> +		if (want_color(branch_use_color))
> +			snprintf(fancy, sizeof(fancy), "%s%s%s",
> +					branch_get_color(BRANCH_COLOR_UPSTREAM),
> +					ref, branch_get_color(BRANCH_COLOR_RESET));
> +		else
> +			strncpy(fancy, ref, sizeof(fancy));

  $ man strncpy | grep -C1 Warning
  The strncpy() function is similar, except that at most n bytes of src are
  copied.  Warning: If there is no null byte among the first n bytes of src,
  the string placed in dest will not be null-terminated.

-Peff