From: Jeff King <peff@peff.net>
Date: Fri, 12 Apr 2013 19:40:12 GMT
Subject: Re: [PATCH 1/3] Make read_index_data() public
Message-ID: <20130412194012.GA5154@sigill.intra.peff.net>
In-Reply-To: <1365787573-597-2-git-send-email-git@cryptocrack.de>

On Fri, Apr 12, 2013 at 07:26:11PM +0200, Lukas Fleischer wrote:

> This allows for reusing the function in convert.c later.
> 
> Also, move it from attr.c to read-cache.c and add a use_index parameter
> to specify a custom index_state since we are no longer enable to access
> the static use_index variable from attr.c.

I'm all for removing duplicated code, but, but I think the name
"read_index_data" is a bit misleading for a global function. I would
expect it to read data from the index (and the argument "path" does not
help clarify that at all).

Can we rename it read_blob_data_from_index_path() or something?

-Peff