From: Jonathan Nieder <jrnieder@gmail.com>
Date: Fri, 12 Apr 2013 02:55:02 GMT
Subject: Re: [PATCH] i18n: make the translation of -u advise in one go
Message-ID: <20130412025501.GB3266@elie.Belkin>
In-Reply-To: <4003e29bb04b122897cefe2a8057266e2428dce5.1365734618.git.worldhello.net@gmail.com>

Hi,

Jiang Xin wrote:

> Since status_vprintf() called by status_printf_ln() can handle eol in
> buffer, we could simply join these lines into one paragraph.

Good idea.

[...]
> --- a/wt-status.c
> +++ b/wt-status.c
> @@ -1223,16 +1223,12 @@ void wt_status_print(struct wt_status *s)
>  		if (s->show_ignored_files)
>  			wt_status_print_other(s, &s->ignored, _("Ignored files"), "add -f");
>  		if (advice_status_u_option && 2000 < s->untracked_in_ms) {
> -			status_printf_ln(s, GIT_COLOR_NORMAL, "");

Tiny nit: I'd suggest keeping the above line, making it:

			status_printf_ln(s, GIT_COLOR_NORMAL, "");
			status_printf_ln(s, GIT_COLOR_NORMAL,
					_("It took ..."
					  "... status')."),
					s->untracked_in_ms / 1000.0);

That way, the message to be translated doesn't start with a newline,
so translators don't have to worry about preserving it (or removing
it if the layout ever changes in the future, etc).

With that change,
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

Thanks.