From: Jeff King <peff@peff.net>
Date: Thu, 11 Apr 2013 05:31:54 GMT
Subject: Re: [PATCH 3/5] Documentation: add caveats about I/O buffering for check-{attr,ignore}
Message-ID: <20130411053154.GD27795@sigill.intra.peff.net>
In-Reply-To: <1365645575-11428-3-git-send-email-git@adamspiers.org>

On Thu, Apr 11, 2013 at 02:59:33AM +0100, Adam Spiers wrote:

> check-attr and check-ignore have the potential to deadlock callers
> which do not read back the output in real-time.  For example, if a
> caller writes N paths out and then reads N lines back in, it risks
> becoming blocked on write() to check-*, and check-* is blocked on
> write back to the caller.  Somebody has to buffer; the pipe buffers
> provide some leeway, but they are limited.
> 
> Thanks to Peff for pointing this out:
> 
>     http://article.gmane.org/gmane.comp.version-control.git/220534
> 
> Signed-off-by: Adam Spiers <git@adamspiers.org>

Thanks, I think the documentation changes look sane.

-Peff