From: Jonathan Nieder <jrnieder@gmail.com>
Date: Tue, 09 Apr 2013 00:18:17 GMT
Subject: Re: [PATCH 1/2] clone: Fix error message for reference repository
Message-ID: <20130409001817.GV30308@google.com>
In-Reply-To: <1365461200-13509-2-git-send-email-aaron@schrab.com>

Aaron Schrab wrote:

> Do not report that an argument to clone's --reference option is not a
> local directory.  Nothing checks for the existence or type of the path
> as supplied by the user; checks are only done for particular contents of
> the supposed directory, so we have no way to know the status of the
> supplied path.

Yes, makes sense.

Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>

My only remaining qualm is that a person could be confused by the
message after trying to pass in --reference=file:///path/to/repo, but
I guess that trial and error would eventually lead such a person in
the right direction.