From: Jonathan Nieder <jrnieder@gmail.com>
Date: Sun, 07 Apr 2013 22:14:58 GMT
Subject: Re: [PATCH 1/2] rev-parse: add --filename-prefix option
Message-ID: <20130407221458.GE19857@elie.Belkin>
In-Reply-To: <ba2c7aa9eaa982306f1d5ad5ff2d26a6e2b8df85.1365364193.git.john@keeping.me.uk>

Hi,

John Keeping wrote:

> This adds a prefix string to any filename arguments encountered after it
> has been specified.

I assume this is a way of passing the prefix in?  In that case, I
think a good UI would be

	git rev-parse --prefix=Documentation/ <usual rev-parse args>

That sounds like a useful thing and would make the meaning very clear.

How does this interact with the following options?

 * --resolve-git-dir some/relative/path
 * master:./path

As for the patch itself, I haven't looked at it closely.  My only
immediate reaction is that I wish it touched Documentation/ and t/. :)

Hope that helps,
Jonathan