From: Simon Ruderich <simon@ruderich.org>
Date: Sun, 07 Apr 2013 19:34:16 GMT
Subject: Re: [PATCH v4 5/6] format-patch: add format.cover-letter configuration
Message-ID: <20130407193415.GB13708@ruderich.org>
In-Reply-To: <1365356784-24872-6-git-send-email-felipe.contreras@gmail.com>

On Sun, Apr 07, 2013 at 12:46:23PM -0500, Felipe Contreras wrote:
> [snip]
>
> +test_expect_success 'cover letter auto' '
> +	mkdir -p tmp &&
> +	test_when_finished "rm -rf tmp;
> +		git config --unset format.coverletter" &&
> +
> +	git config format.coverletter auto &&

    test_config format.coverletter auto &&

takes automatically care of the git config --unset cleanup.

I'm not sure if it's better to use test_when_finished with rm or
just && rm -rf tmp at the end of the test in case someone wants
to look at the output.

Regards
Simon
-- 
+ privacy is necessary
+ using gnupg http://gnupg.org
+ public key id: 0x92FEFDB7E44C32F9